search

TokTok / hs-msgpack-binary

Haskell implementation of MessagePack / msgpack.org
http://msgpack.org/
Other
16 stars 10 forks source link

Separate msgpack types from serialization details [2/2] #43

Closed SX91 closed 6 years ago

SX91 commented 7 years ago

This is the second part of https://github.com/TokTok/hs-msgpack-types/pull/1

This change is Reviewable

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

iphydf commented 7 years ago

Please enable the checkbox "Allow edits from maintainers." on the bottom right.

SX91 commented 7 years ago

@iphydf It's already checked. And I've fixed version to be a patch bump.

iphydf commented 7 years ago

Any idea why appveyor is failing?

iphydf commented 7 years ago
:lgtm_strong:

Review status: 0 of 14 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable

iphydf commented 7 years ago

@SX91 you have push access to this repo, so once it's ready, feel free to merge.

iphydf commented 7 years ago

@SX91 turns out, chocolatey is broken. #44 has a fix. Let's release your PR as 0.0.11.

SX91 commented 7 years ago

So, what about actually merging this?

robinlinden commented 7 years ago
:lgtm_strong:

Reviewed 13 of 14 files at r1, 1 of 1 files at r5. Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from Reviewable