search

TokTok / spec

Tox Protocol Specification
https://toktok.ltd/spec
GNU General Public License v3.0
33 stars 13 forks source link

Improvement v3 #36

Closed zetok closed 8 years ago

zetok commented 8 years ago

This change is Reviewable

CLAassistant commented 8 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

nbraud commented 8 years ago

@zetok Are the commits from #34 and #35 included on purpose? If so, should #34 and #35 be closed?

zetok commented 8 years ago

Are the commits from #34 and #35 included on purpose?

Yep.

If so, should #34 and #35 be closed?

If this PR gets "merged" first, yes. If things will be pushed on master incrementally, it will make it possible to do review on per-change basis.

That is, assuming that there was no CLA – with it, it doesn't look like those changes will be used in TokTok's tox spec.

iphydf commented 8 years ago

Closing to remove old "Reviewable" PRs. Reopen for github review if necessary.