search

TokTok / spec

Tox Protocol Specification
https://toktok.ltd/spec
GNU General Public License v3.0
32 stars 13 forks source link

Update dht state section #39

Closed iphydf closed 8 years ago

iphydf commented 8 years ago

This change is Reviewable

nbraud commented 8 years ago

Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.

spec.md, line 425 [r1] (raw file):

Every DHT node contains the following state:

-   DHT Key Pair: The Key Pair used to communicate with other DHT nodes. It is

Is it used for signing? Encryption? Both?

[spec.md, line 429 [r1]](https://reviewable.io:443/reviews/toktok/tox-spec/39#-KJg6JbPCVdSIPq4KdCZ:-KJg6JbPCVdSIPq4KdC:-938291510) (raw file):_


-   DHT Close List: A set of Node Infos of nodes that are close to the DHT
    Public Key (public part of the DHT Key Pair). It uses the

What is “It”?

spec.md, line 434 [r1] (raw file):


-   DHT Search List: A list of Public Keys of nodes that the DHT node is
    searching for associated with a DHT Search Entry.

“searching for, associated with a DHT Search entry.”

spec.md, line 460 [r1] (raw file):

structures from memory.

Iteration order is first Close List, then Search List. Each list follows the

Either “The iteration order is” or “The iteration is first done on the Close List, then on the Search List”.

spec.md, line 468 [r1] (raw file):


When adding a node to the state, the search entry for the node's public key, if
such exists, is updated to contain the new Node Info. All k-buckets that

Shoudn't it be “if it exists”?

Comments from Reviewable

iphydf commented 8 years ago

Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.

spec.md, line 425 [r1] (raw file):

Previously, nbraud (Nicolas Braud-Santoni) wrote… > Is it used for signing? Encryption? Both? >

The private key is used to sign, the public key is used by the second party to encrypt messages targetted at us. I'll check if this is explained elsewhere. The node state documentation does not seem like the right place to explain this.

_spec.md, line 429 [r1] (raw file):_

Previously, nbraud (Nicolas Braud-Santoni) wrote… > What is “It”? >

Done.

_spec.md, line 434 [r1] (raw file):_

Previously, nbraud (Nicolas Braud-Santoni) wrote… > “searching for, associated with a DHT Search entry.” >

Done.

_spec.md, line 460 [r1] (raw file):_

Previously, nbraud (Nicolas Braud-Santoni) wrote… > Either “The iteration order is” or “The iteration is first done on the Close List, then on the Search List”. >

PTAL.

spec.md, line 468 [r1] (raw file):

Previously, nbraud (Nicolas Braud-Santoni) wrote… > Shoudn't it be “if it exists”? >

Done.

Comments from Reviewable