search

TokTok / spec

Tox Protocol Specification
https://toktok.ltd/spec
GNU General Public License v3.0
33 stars 13 forks source link

Update dht node state text; add missing packet kind. #40

Closed iphydf closed 8 years ago

iphydf commented 8 years ago

This change is Reviewable

nbraud commented 8 years ago

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

_spec.md, line 131 at r1 (raw file):_

## Box

The Tox protocol differentiates between two types of text: Plain Text and

This makes it sound like this is actual text (as in, ASCII or UTF-8 or somesuch)

spec.md, line 492 at r1 (raw file):

Removing a node info from the state removes it from all k-buckets. If a search
entry for the removed node's public key existed, the node info in that search
entry is unset. The search entry itself is not removed.

This is a strange way to say it: the search entry ends up referring to different node info.

spec.md, line 4060 at r1 (raw file):


See the [spec](https://github.com/msgpack/msgpack/blob/master/spec.md) of
msgpack for information on the binary representation.

This doesn't say anything more about what is being serialized as MsgPack. On one hand, this is information we need to have somewhere, on the other hand it probably doesn't belong in the protocol spec.

Comments from Reviewable

GrayHatter commented 8 years ago

Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.

[spec.md, line 135 at r1](https://reviewable.io:443/reviews/toktok/spec/40#-KRyWaH5CvbCniKB2ZZz:-KRyWaH5CvbCniKB2Z-:blvd43s) (raw file):_

Text can be Sensitive or Non Sensitive. Sensitive Plain Text must be
transformed into Cipher Text using the encryption function before it can be
transmitted over untrusted data channels.

Suggest replace with

Sensitive Plain Text must be transformed into Cipher Text using the encryption function before it can be transmitted over any data channel.

Comments from Reviewable