search

TokTok / spec

Tox Protocol Specification
https://toktok.ltd/spec
GNU General Public License v3.0
32 stars 13 forks source link

Proofreading #42

Closed SomeoneSerge closed 7 years ago

SomeoneSerge commented 7 years ago

I'm going to read spec.md (reading just in spare time, which is little) and then maybe to try to reimplement Tox Protocol based on the specification (just for learning, you know). As I advance in reading I'm going to fix typos, leave notes and ask questions -- I'll be pushing changes into this PR

Some questions are placed in the paper and marked with "TODO:" prefix

At the moment I'd propose adding goals and threat model part into the beginning of specification, so that it can serve as purpose and intuition for the rest of document and future reimplementations. I also noted that threat model isn't clearly stated anywhere, which leads to some misunderstandings in discussions (e.g. this rather implicit tradeoff between anonymity and things like realtime AV)

Also I wanted to know if kademlia's least-recent-seen eviction policy (see diffs or referenced paper for rationale) was considered and if it was why was it rejected

Also, I disclaim, ugh, everything (see commitmsg for all these "I'm not ...")

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

iphydf commented 7 years ago

Thanks, can you check the formatting? Our travis build reformats the code in a canonical way. Perhaps you can adopt its formatting. If you feel that it's doing the wrong thing (i.e. it's producing semantically incorrect code), let me know.

iphydf commented 7 years ago

LGTM, can you squash all commits into one, and give it some nice commit message?