Closed robinlinden closed 8 years ago
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.
spec.md, line 4007 at r1 (raw file):
| `2` | `uint16_t` Size of the friend request message (BE) | | `128` | Name as a UTF-8 encoded string | | `2` | `uint16_t` Size of the name (BE) |
Size in bytes right?
Comments from Reviewable
Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.
spec.md, line 4003 at r1 (raw file):
| `1` | `uint8_t` Status | | `32` | Long term public key | | `1024` | Friend request message as a UTF-8 encoded string |
Does toxcore promise utf8, or valid utf8?
Comments from Reviewable
Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.
_spec.md, line 4003 at r1 (raw file):_
Toxcore doesn't check what we're receiving besides that it's not too long and the spec says utf8. I think we only promise utf8.
spec.md, line 4007 at r1 (raw file):
Correct.
Comments from Reviewable
Fix formatting (see https://travis-ci.org/TokTok/spec/builds/177544832#L246).
Reviewed 1 of 1 files at r3. Review status: all files reviewed at latest revision, 2 unresolved discussions.
Comments from Reviewable
Reviewed 1 of 1 files at r3. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
See #281 for PR with save format update.
This change is