TokTok / spec

Tox Protocol Specification
https://toktok.ltd/spec
GNU General Public License v3.0
33 stars 13 forks source link

Use specified length #60

Closed Diadlo closed 6 years ago

Diadlo commented 7 years ago

One the top of the spec variable length declared as [0,]


This change is Reviewable

robinlinden commented 7 years ago

For Travis to pass you have to strip the superfluous whitespace in the tables.

Diadlo commented 7 years ago

@robinlinden Fixed

iphydf commented 6 years ago

Looks good, can you make this change on https://github.com/TokTok/hs-toxcore? We can then merge it back into the spec.

Diadlo commented 6 years ago

@iphydf Why spec moved under haskell implementation of toxcore?

iphydf commented 6 years ago

@Diadlo it has been there pretty much from the start. Why: because the implementation is next to the specification. We can look at the spec in latex and see the haskell model implementation right between the lines.

Diadlo commented 6 years ago

@iphydf Why not in c-toxcore? C model shouldn't be right between the lines?

iphydf commented 6 years ago

@Diadlo no, because C is not a model implementation. It's an efficient, verbose, and non-obvious implementation. The Haskell implementation is intended to be very clear, "obviously correct" (as opposed to "arguably correct", which is a property of the C implementation).

iphydf commented 6 years ago

Please enable the checkbox "Allow edits from maintainers." on the bottom right.

Diadlo commented 6 years ago

@iphydf Done