TokTok / toktok-android

Tox Android Client
https://toktok.ltd/
GNU General Public License v3.0
34 stars 12 forks source link

Move onClick listeners from scala-style to java-style. #16

Closed iphydf closed 6 years ago

iphydf commented 6 years ago

No lambdas, only anonymous inner classes. That's android java for you.


This change is Reviewable

robinlinden commented 6 years ago

The translation to to Java looks correct, so :lgtm_strong:, but I'd prefer if we stuck with Scala.


Reviewed 34 of 34 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

iphydf commented 6 years ago

@robinlinden there is no translation to Java happening in this PR.

robinlinden commented 6 years ago

@iphydf Java supports the Scala-style code you changed?