TokTok / toxic

An ncurses-based Tox client
https://toktok.ltd/
GNU General Public License v3.0
27 stars 4 forks source link

chore: Update the static build script #373

Closed nurupo closed 5 months ago

nurupo commented 5 months ago

This change is Reviewable

nurupo commented 5 months ago

Codacy:

Expressions don't expand in single quotes, use double quotes for that.

sed -i 's/man_MANS = $(MANPAGE)/@BUILD_DOCS_TRUE@man_MANS = $(MANPAGE)/g' docs/cmdline-opts/Makefile.in

That's intentional, we don't want to expand those variables.

nurupo commented 5 months ago

@JFreegman please take a look and merge.

Note the addition of the --pull=always flag in the docker run command. Would be nice if the next static toxic build used an updated Alpine image.

Also note that --pull=always just un-tags the previous alpine:latest, it doesn't delete it, so the images might add up over time and you might want to run some docker cleanup commands to delete the unused images and reclaim the disk space.