search

TokTok / website

The TokTok website
https://toktok.ltd/
GNU General Public License v3.0
10 stars 55 forks source link

Add favicon. #106

Closed iphydf closed 6 years ago

iphydf commented 6 years ago

This change is Reviewable

robinlinden commented 6 years ago

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

toktok/editor.html, line 9 at r1 (raw file):

  <head>
    <meta charset="utf-8" />
    <link rel="shortcut icon" type="image/svg" href="{{ relative }}static/img/cedar.png"/>

"The shortcut link type is often seen before icon, but this link type is non-conforming, ignored and web authors must not use it anymore." - https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types

Comments from Reviewable

iphydf commented 6 years ago

Review status: 2 of 5 files reviewed at latest revision, 1 unresolved discussion.

toktok/editor.html, line 9 at r1 (raw file):

Previously, robinlinden (Robin Lindén) wrote…
"The shortcut link type is often seen before icon, but this link type is non-conforming, ignored and web authors must not use it anymore." - https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types

Done.

Comments from Reviewable

robinlinden commented 6 years ago
:lgtm_strong:

Reviewed 4 of 4 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable