Add linkchecker and markdown linter.

iphydf commented 7 years ago

This change is

robinlinden commented 7 years ago

Reviewed 13 of 13 files at r1. Review status: all files reviewed at latest revision, 5 unresolved discussions.

.md-style.rb, line 1 at r1 (raw file):

all

Can we sort the rules in ascending order? Regardless of whether they're excluded or configured. Makes going through them together with https://github.com/mivok/markdownlint/blob/master/docs/RULES.md easier.

toktok/spec.md, line 8 at r1 (raw file):

---

*   The line below will tell kramdown to generate the ToC on this line.

You can replace * with - so it matches the other lists. It only has to be a list marker. You can even make it 1. for a numbered list.

toktok/design/testing.md, line 14 at r1 (raw file):

validate any [Tox Core Protocol](https://toktok.github.io/spec)
implementation, including the C reference implementation
[libtoxcore](https://github.com/toktok/c-toxcore).  We aim to create an

Why 2 spaces here?

toktok/design/testing.md, line 82 at r1 (raw file):

remain untested and must be tested in the implementation-specific test suite.
This includes networking, but also any functionality that relies on
randomness.  Notably this includes generating key pairs and nonces. Tests that

Why 2 spaces here?

toktok/design/testing.md, line 105 at r1 (raw file):


[Hspec](https://hspec.github.io/) will be used to write the test
specification.  Every Haskell module `M` will have an associated `${M}Spec`

Why 2 spaces?

Comments from Reviewable

iphydf commented 7 years ago

Review status: all files reviewed at latest revision, 5 unresolved discussions.

.md-style.rb, line 1 at r1 (raw file):

Previously, robinlinden (Robin Lindén) wrote…

Can we sort the rules in ascending order? Regardless of whether they're excluded or configured. Makes going through them together with https://github.com/mivok/markdownlint/blob/master/docs/RULES.md easier.

Done.

toktok/spec.md, line 8 at r1 (raw file):

Previously, robinlinden (Robin Lindén) wrote…