TokTok / website

The TokTok website
https://toktok.ltd/
GNU General Public License v3.0
10 stars 54 forks source link

Make reviewers column more readable in pr-table. #19

Closed robinlinden closed 7 years ago

robinlinden commented 7 years ago

This change is Reviewable

iphydf commented 7 years ago

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


toktok/pulls.html, line 61 at r1 (raw file):

            "<td>" + json[i][j].prTitle      + "</td>" +
            "<td>" + stateIcon[json[i][j].prState] + "</td>" +
            "<td>" + json[i][j].prReviewers.toString().replace(/,/g , ", ") + "</td>";

.join(", ") does the same thing, right?


Comments from Reviewable

iphydf commented 7 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

robinlinden commented 7 years ago

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


toktok/pulls.html, line 61 at r1 (raw file):

Previously, iphydf wrote…
`.join(", ")` does the same thing, right?

You're right. Done.


Comments from Reviewable

cebe commented 7 years ago
:lgtm_strong:

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

iphydf commented 7 years ago

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

iphydf commented 7 years ago
:lgtm_strong:

Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable