Closed robinlinden closed 7 years ago
Reviewed 5 of 5 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Reviewed 5 of 5 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.
toktok/static/js/pr-table.js, line 67 at r1 (raw file):
twemoji.parse(prTable, { callback: function(icon, options) { return '{{ relative }}static/img/emoij/' + options.size + '/' + icon + '.png';
as per IRC, this does not work. {{ relative }}
is not parsed.
Comments from Reviewable
Review status: 3 of 5 files reviewed at latest revision, 1 unresolved discussion.
toktok/static/js/pr-table.js, line 67 at r1 (raw file):
as per IRC, this does not work. `{{ relative }}` is not parsed.
Done. Changed this to be done the way you suggested on IRC.
Comments from Reviewable
Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Add easy way of properly including js. Add folder for js content.
This change is