TokTok / website

The TokTok website
https://toktok.ltd/
GNU General Public License v3.0
10 stars 54 forks source link

Refactor out pr-table js into its own file. #27

Closed robinlinden closed 7 years ago

robinlinden commented 7 years ago

Add easy way of properly including js. Add folder for js content.


This change is Reviewable

iphydf commented 7 years ago

Reviewed 5 of 5 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

iphydf commented 7 years ago
:lgtm_strong:

Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

cebe commented 7 years ago

Reviewed 5 of 5 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.


toktok/static/js/pr-table.js, line 67 at r1 (raw file):

        twemoji.parse(prTable, {
            callback: function(icon, options) {
              return '{{ relative }}static/img/emoij/' + options.size + '/' + icon + '.png';

as per IRC, this does not work. {{ relative }} is not parsed.


Comments from Reviewable

robinlinden commented 7 years ago

Review status: 3 of 5 files reviewed at latest revision, 1 unresolved discussion.


toktok/static/js/pr-table.js, line 67 at r1 (raw file):

Previously, cebe (Carsten Brandt) wrote…
as per IRC, this does not work. `{{ relative }}` is not parsed.

Done. Changed this to be done the way you suggested on IRC.


Comments from Reviewable

cebe commented 7 years ago

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

cebe commented 7 years ago
:lgtm_strong:

Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

iphydf commented 7 years ago

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable