search

TokTok / website

The TokTok website
https://toktok.ltd/
GNU General Public License v3.0
10 stars 54 forks source link

Added .travis.yml, Makefile and renamed src/ to toktok/ #3

Closed robinlinden closed 7 years ago

robinlinden commented 7 years ago

This change is Reviewable

cebe commented 7 years ago

Reviewed 88 of 88 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Makefile, line 20 at r1 (raw file):

  cd $(WEB_NAME) && git add .
  cd $(WEB_NAME) && git commit -a --amend -m'Updated website'
  cd $(WEB_NAME) && git push --force

why amend and force push and not commit/push normally?

Comments from Reviewable

iphydf commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Makefile, line 20 at r1 (raw file):

Previously, cebe (Carsten Brandt) wrote…
why amend and force push and not commit/push normally?

Because we have no interest in history for the target website repo. The source repo is versioned, but toktok.github.io is just a place where we deploy html. Keeping that repo small makes the build a bit faster. It also makes other builds that perhaps will push built artifacts to the website faster. In case of artifacts, we'd definitely not want to version those.

Comments from Reviewable

iphydf commented 7 years ago
:lgtm:

Reviewed 88 of 88 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable