Closed robinlinden closed 7 years ago
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
see comment below.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.
.travis.yml, line 38 at r2 (raw file):
&& echo "[filtering]" > ~/.linkchecker/linkcheckerrc \ && echo "ignorewarnings=http-robots-denied" >> ~/.linkchecker/linkcheckerrc - linkchecker --ignore-url "https://travis-ci.org.*" --ignore-url "irc://.*" toktok-site || true
this conflicts with the changes to makefile and travis.yml on master. This change should be moved to the makefile check target.
Comments from Reviewable
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.
.travis.yml, line 38 at r2 (raw file):
this conflicts with the changes to makefile and travis.yml on master. This change should be moved to the makefile check target.
Done. Rebased on master and solved the merge conflict by moving this to the Makefile.
Comments from Reviewable
Reviewed 2 of 2 files at r3. Review status: all files reviewed at latest revision, 2 unresolved discussions.
Makefile, line 51 at r3 (raw file):
check: mkdir -p ~/.linkchecker/
Directory might already exist, add a "-" before "mkdir" to allow a failure. Also, if the user's home directory was missing, there's very little chance they'd actually have permission to create it; you can remove the "-p" option.
Comments from Reviewable
Reviewed 2 of 2 files at r3. Review status: all files reviewed at latest revision, 1 unresolved discussion.
Comments from Reviewable
Reviewed 1 of 2 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Reviewed 2 of 2 files at r3. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
This change is