search

TokTok / website

The TokTok website
https://toktok.ltd/
GNU General Public License v3.0
10 stars 54 forks source link

Lots of changes to the PR table. #32

Closed robinlinden closed 7 years ago

robinlinden commented 7 years ago

Number column only links to reviewable. Branch now links to GitHub. Moved username tooltip to title column. Tooltips prettier and better aligned.

Oh, and branches and text in the title should now break after underscores and never in the middle of words.

This change is Reviewable

iphydf commented 7 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

toktok/static/js/pr-table.js, line 48 at r1 (raw file):

          var githubBranch =
            " <a href='https://github.com/TokTok/" + json[i][j].prRepoName +
            "/" + json[i][j].prNumber + "'>" + json[i][j].prBranch.replace(/_/g, "_<wbr>") +

This removed the "/pull/" part but it's needed.

Comments from Reviewable

robinlinden commented 7 years ago

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.

toktok/static/js/pr-table.js, line 48 at r1 (raw file):

Previously, iphydf wrote…
This removed the "/pull/" part but it's needed.

Oops. Fixed.

Comments from Reviewable

iphydf commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.

toktok/static/js/pr-table.js, line 48 at r2 (raw file):

          var githubBranch =
            " <a href='https://github.com/TokTok/" + json[i][j].prRepoName +
            "/pull/" + json[i][j].prNumber + "'>" +

Reviewable doesn't have a "/pull/" here. It works, but then redirects to the url without "/pull/".

Comments from Reviewable

robinlinden commented 7 years ago

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.

toktok/static/js/pr-table.js, line 48 at r2 (raw file):

Previously, iphydf wrote…
Reviewable doesn't have a "/pull/" here. It works, but then redirects to the url without "/pull/".

Done. I misplaced it when switching the places of githubBranch and reviewableNumber.

Comments from Reviewable

iphydf commented 7 years ago
:lgtm_strong:

Reviewed 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

iphydf commented 7 years ago

@cebe

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

cebe commented 7 years ago
:lgtm_strong:

Reviewed 1 of 2 files at r1, 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

iphydf commented 7 years ago

Reviewed 2 of 2 files at r4. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

iphydf commented 7 years ago

@cebe can you review again? I've rebased it.

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

robinlinden commented 7 years ago

Reviewed 2 of 2 files at r4. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

subliun commented 7 years ago
:lgtm_strong:

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

subliun commented 7 years ago

Reviewed 2 of 2 files at r4. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable