TokTok / website

The TokTok website
https://toktok.ltd/
GNU General Public License v3.0
10 stars 55 forks source link

Fix makefile dependencies on changelog and roadmap. #40

Closed iphydf closed 7 years ago

iphydf commented 7 years ago

This change is Reviewable

cebe commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Makefile, line 12 at r1 (raw file):

# build the website with jekyll
#
toktok-site: $(shell which jekyll) $(shell find toktok -type f) emoij changelog roadmap spec

I intentionally avoided the site building depend on spec because we have pandoc as optional in the readme. I'm fine with this change but then the "optional" note should be removed in the README.


Comments from Reviewable

robinlinden commented 7 years ago

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

iphydf commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Makefile, line 12 at r1 (raw file):

Previously, cebe (Carsten Brandt) wrote…
I intentionally avoided the site building depend on spec because we have pandoc as optional in the readme. I'm fine with this change but then the "optional" note should be removed in the README.

Made it optional by checking if pandoc exists before executing it.


Comments from Reviewable

robinlinden commented 7 years ago
:lgtm_strong:

Reviewed 1 of 1 files at r4. Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

cebe commented 7 years ago
:lgtm_strong:

Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

robinlinden commented 7 years ago

Reviewed 1 of 1 files at r5. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

cebe commented 7 years ago

Reviewed 1 of 1 files at r2, 1 of 1 files at r5. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable