TokTok / website

The TokTok website
https://toktok.ltd/
GNU General Public License v3.0
10 stars 54 forks source link

Remove links to rust-lang.org. #41

Closed robinlinden closed 7 years ago

robinlinden commented 7 years ago
  1. They fail the linkchecker with the following error:
    URL        `https://www.rust-lang.org/en-US/documentation.html'
    Name       `Start with Rust'
    Parent URL file:///home/travis/build/TokTok/website/toktok-site/get-started.html, line 130, col 7
    Real URL   https://www.rust-lang.org/en-US/documentation.html
    Check time 0.592 seconds
    Result     Error: SSLError: [Errno 1] _ssl.c:510: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure
  2. We don't currently have any Rust code in the Toktok repos.

This change is Reviewable

iphydf commented 7 years ago
:lgtm_strong:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Zer0-One commented 7 years ago
:lgtm_strong:

Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Zer0-One commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

zetok commented 7 years ago

They fail the linkchecker with the following error

It would be better to open an issue against rust infrastructure, so that the actual problem would be fixed for everyone, rather than making a specific to repo workaround.

We don't currently have any Rust code in the Toktok repos.

AFAIK that is to be changed, so having learning resources in place already would be a good idea.


Review status: all files reviewed at latest revision, 1 unresolved discussion.


toktok/get-started.md, line 10 at r1 (raw file):

Collection of resources that will help you get started writing code.

When in doubt, you can always [contact us](index.html#contact-us). :)

Why adding a dot and removing hyphen?

With this change it looks unnatural.


Comments from Reviewable

iphydf commented 7 years ago

It'll be easy to add back.


Review status: all files reviewed at latest revision, 1 unresolved discussion.


toktok/get-started.md, line 10 at r1 (raw file):

Previously, zetok wrote…
Why adding a dot and removing hyphen? With this change it looks unnatural.

It's consistent. Perhaps we should replace the ":)" on the site with ":-)" elsewhere. @robinlinden revert this change - let's just get linkchecker working and then make other changes.


Comments from Reviewable

iphydf commented 7 years ago

https://github.com/rust-lang/rust-www/issues/686


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

robinlinden commented 7 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


toktok/get-started.md, line 10 at r1 (raw file):

Previously, iphydf wrote…
It's consistent. Perhaps we should replace the ":)" on the site with ":-)" elsewhere. @robinlinden revert this change - let's just get linkchecker working and then make other changes.

Done.


Comments from Reviewable

iphydf commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

fcore117 commented 7 years ago

https://www.rust-lang.org/en-US/community.html Person with rust skills could present Tox spec somewhere in community and perhaps interested people will help to create Rust based implementation.

Contact with rust-lang.org to fix errors ?

fcore117 commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

iphydf commented 7 years ago

I did contact them. I filed a ticket on their www repository.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable