Closed robinlinden closed 7 years ago
Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
They fail the linkchecker with the following error
It would be better to open an issue against rust infrastructure, so that the actual problem would be fixed for everyone, rather than making a specific to repo workaround.
We don't currently have any Rust code in the Toktok repos.
AFAIK that is to be changed, so having learning resources in place already would be a good idea.
Review status: all files reviewed at latest revision, 1 unresolved discussion.
toktok/get-started.md, line 10 at r1 (raw file):
Collection of resources that will help you get started writing code. When in doubt, you can always [contact us](index.html#contact-us). :)
Why adding a dot and removing hyphen?
With this change it looks unnatural.
Comments from Reviewable
It'll be easy to add back.
Review status: all files reviewed at latest revision, 1 unresolved discussion.
toktok/get-started.md, line 10 at r1 (raw file):
Why adding a dot and removing hyphen? With this change it looks unnatural.
It's consistent. Perhaps we should replace the ":)" on the site with ":-)" elsewhere. @robinlinden revert this change - let's just get linkchecker working and then make other changes.
Comments from Reviewable
https://github.com/rust-lang/rust-www/issues/686
Review status: all files reviewed at latest revision, 1 unresolved discussion.
Comments from Reviewable
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.
toktok/get-started.md, line 10 at r1 (raw file):
It's consistent. Perhaps we should replace the ":)" on the site with ":-)" elsewhere. @robinlinden revert this change - let's just get linkchecker working and then make other changes.
Done.
Comments from Reviewable
Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.
Comments from Reviewable
https://www.rust-lang.org/en-US/community.html Person with rust skills could present Tox spec somewhere in community and perhaps interested people will help to create Rust based implementation.
Contact with rust-lang.org to fix errors ?
Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
I did contact them. I filed a ticket on their www repository.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
This change is