Closed robinlinden closed 7 years ago
Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
make lint
seems unhappy about this:
$ make lint
mdl -w -s .md-style.rb toktok
toktok/pulls.md: Kramdown Warning: No link definition for link ID 'twemoji-2.2.3.min.js, pr-table.js' found on line 6
make: *** [lint] Error 2
seems it does not understand the meta data headers and thinks you are using a link here [ ... ]
but forgot the parenthesis for the url.
according to its help message:
-i, --[no-]ignore-front-matter Ignore YAML front matter
adding -i
to the mdl call should fix this.
Easy fix: use yaml style arrays.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
@iphydf my fix seems better :)
Agreed - if it works. @robinlinden try @cebe's fix first.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
Markdown generation in this file wasn't working before since I had given it a .html extension instead of the .md I should have used.
This change is