TokTok / website

The TokTok website
https://toktok.ltd/
GNU General Public License v3.0
10 stars 54 forks source link

Switch the pulls file over to using markdown. #48

Closed robinlinden closed 7 years ago

robinlinden commented 7 years ago

Markdown generation in this file wasn't working before since I had given it a .html extension instead of the .md I should have used.


This change is Reviewable

cebe commented 7 years ago
:lgtm_strong:

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

iphydf commented 7 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

cebe commented 7 years ago

make lint seems unhappy about this:

$ make lint
mdl -w -s .md-style.rb toktok
toktok/pulls.md: Kramdown Warning: No link definition for link ID 'twemoji-2.2.3.min.js, pr-table.js' found on line 6
make: *** [lint] Error 2

seems it does not understand the meta data headers and thinks you are using a link here [ ... ] but forgot the parenthesis for the url.

cebe commented 7 years ago

according to its help message:

    -i, --[no-]ignore-front-matter   Ignore YAML front matter

adding -i to the mdl call should fix this.

iphydf commented 7 years ago

Easy fix: use yaml style arrays.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

cebe commented 7 years ago

@iphydf my fix seems better :)

iphydf commented 7 years ago

Agreed - if it works. @robinlinden try @cebe's fix first.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable