Closed iphydf closed 7 years ago
@zx2c4 does this note look reasonable?
I will work on a more detailed set of security advisories later. For now, this is all I had time for.
Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions.
toktok/index.md, line 33 at r1 (raw file):
Neither the Tox protocol nor the implementation have undergone peer review, and its exact security properties and network behaviour and not
"and not" -> "are not"
toktok/repos.md, line 8 at r1 (raw file):
--- You can file bugs against one of the TokTok projects on Github. Build status
"bug reports" instead of "bugs".
Comments from Reviewable
toktok/index.md, line 36 at r1 (raw file):
well-understood, yet. We are actively working on improving that situation. Until said peer review, Tox is not recommended for use cases that require proven high assurance security.
“proven, high-assurance security”
Comments from Reviewable
Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, 3 unresolved discussions.
Comments from Reviewable
assuming those two nitpicks are handled.
Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.
Comments from Reviewable
Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions.
Comments from Reviewable
Reviewed 1 of 2 files at r2. Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.
Comments from Reviewable
Reviewed 2 of 2 files at r3. Review status: all files reviewed at latest revision, 1 unresolved discussion.
Comments from Reviewable
Reviewed 1 of 2 files at r2. Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.
Comments from Reviewable
Please take another look. I have added an invitation to report security issues. It may not be strictly necessary as it should be implied.
Review status: all files reviewed at latest revision, 3 unresolved discussions.
toktok/index.md, line 33 at r1 (raw file):
"and not" -> "are not"
Done.
toktok/index.md, line 36 at r1 (raw file):
“proven, high-assurance security”
Done.
toktok/repos.md, line 8 at r1 (raw file):
"bug reports" instead of "bugs".
Done.
Comments from Reviewable
Reviewed 2 of 2 files at r3. Review status: all files reviewed at latest revision, 1 unresolved discussion.
Comments from Reviewable
Reviewed 1 of 2 files at r3. Review status: all files reviewed at latest revision, 1 unresolved discussion.
Comments from Reviewable
Reviewed 2 of 2 files at r2, 1 of 2 files at r3. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
This change is