TokamakUI / Tokamak

SwiftUI-compatible framework for building browser apps with WebAssembly and native apps for other platforms
Apache License 2.0
2.62k stars 111 forks source link

ViewModifier, causes bounds overflow #541

Open shial4 opened 1 year ago

shial4 commented 1 year ago

Describe the bug Adding ViewModifier to view causes bounds overflow crash, in any browser. You need to have enough examples for it to happen. (2x didn't trigger) but below code, does the trick for me

HStack {
                Rectangle()
                    .fill(Color.purple)
                    .frame(width: 100, height: 100)
                    .onTapGesture() {
                        print("🟢 1st gesture")
                    }
                    .onTapGesture() {
                        print("🟢 2nd gesture, should not be called")
                    }
                    .onTapGesture() {
                        print("🟢 3rd gesture, should not be called")
                    }
                    .simultaneousGesture(
                        TapGesture().onEnded({ _ in
                            print("🟢 simultaneousGesture gesture")
                        })
                    )
                    .onLongPressGesture {
                        print("🟢 onLongPressGesture")
                    }
                Text("Tap Parent")
            }
            .background(
                Color.gray
                    .onTapGesture() {
                        print("🩶 Background gesture")
                    }
            )
            .onTapGesture() {
                print("🔵 Parent gesture")
            }

Used code to trigger the issue

private struct GesturePreferenceModifier<G: Gesture>: ViewModifier {
    let gesture: G

    func body(content: Content) -> some View {
        GestureView( gesture: gesture, content: content )
    }
}

with the modifier applied like this:

modifier(GesturePreferenceModifier(gesture: gesture.body))

To Reproduce Steps to reproduce the behavior:

  1. Create a preference key
  2. Create HStack View with modifier applied to it and its subviews
  3. change state (i.e. on tap)
  4. See error

Expected behavior App works as expected

Screenshots

Desktop (please complete the following information):