search

TokenEngineeringCommunity / BalancerPools_Model

cadCAD model to simulate Balancer AMMs
MIT License
54 stars 29 forks source link

NB update #67

Closed AngelaKTE closed 3 years ago

AngelaKTE commented 3 years ago

added plots for

and finally cleared output in 2nd commit

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

AngelaKTE commented 3 years ago

Please merge NBupdate to dev to include final version of notebook @Ramarti

markusbkoch commented 3 years ago

@AngelaKTE IMO the same point I made in #45 about dai_balance dominating weth_balance renders the ratio indicator as it currently stands somewhat meaningless image

Instead, I'd suggest the ratio of value in each token image

If you can make this a normalized stacked area chart (and I'm sure you can make a much more visually appealing version than the following 🙈 ), it would be even better to showcase the fact that the value of the tokens held by the pool constantly hovers the pre-defined weights, as per the design image