TolgaTatli / Halve

Stylish Two-Column Jekyll Theme
https://tolgatatli.github.io/Halve/
MIT License
290 stars 356 forks source link

site.baseurl should be used #18

Open shellscape opened 8 years ago

shellscape commented 8 years ago

It would seem that site.url is being slightly misused. Ideally, that variable is only used for permalinks and things like RSS feed urls in the <head> element. site.baseurl should be used for asset locations, etc. This will allow local serving to mirror production serving without having to modify hosts or implement custom routing. For example:

<a href="{{ site.url }}" class="logo"><img src="{{ site.url }}/images/{{ site.logo }}"></a>

should be

<a href="{{ site.baseurl }}" class="logo"><img src="{{ site.url }}/images/{{ site.logo }}"></a>