Install mypy in tests - Githubissues

Toloka / crowd-kit

Control the quality of your labeled data with the Python tools you already know.

https://crowd-kit.readthedocs.io/

Other

213 stars 16 forks source link

Install mypy in tests #80

Closed pilot7747 closed 1 year ago

pilot7747 commented 1 year ago

Now test fail because of mypy not found, try to install it directly

Checklist

[x] I have read the CONTRIBUTING document
[x] I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

dustalov commented 1 year ago

mypy is already required as a development dependency: https://github.com/Toloka/crowd-kit/blob/ff36f90a3ccf46f589850aae67d20df1ca4e9518/setup.cfg#L56

Please investigate if it is installed properly via pipenv.

pilot7747 commented 1 year ago

In parallel PR tests say that mypy isn't installed. Here the tests also fail but for some other reason. Seems like a change in mypy, need to investigate

dustalov commented 1 year ago

Yep, something definitely happened. Everything worked until recently.

https://github.com/Toloka/crowd-kit/actions/runs/5520833629/job/14950582157

dustalov commented 1 year ago

Fixed in the upstream.