Add `formattingToggle.statusBarLabel` settings

[dgrebb]

What?

This is a first draft to address #67.

How?

Adds formattingToggle.text to support custom Status Bar label text.

This can be enhanced in multiple ways:

• add support for variations of text on enabled/disabled status
• add support for customization of of enabled/disabled icon

I'd be happy to write tests and build the above out further with separate PRs. Please @ me if interested and I'll wrap up this PR with tests, changes to naming convention, separating statusBarText logic out into its own helper, etc.

Thank you for your work on this excellent extension, @Tom-Bonnike!

[dgrebb]

Note on this @Tom-Bonnike — the .vsix build included here has the changes.

I didn't want to do any version bumping without sharing first :)

[dgrebb]

@Tom-Bonnike thank you for the feedback!

I'll address all of the above and resolve each comment. Thoughts on adding icon with this object composition?

formattingToggle.statusBar: {
  enabled: "Formatting enabled: $(check)",
  disabled: "Formatting disabled: $(x)"
}

We could also split apart icon and text, but I'm not sure the added complexity is worth it?

Thanks again — I'll update this soon.

[dgrebb]

@Tom-Bonnike I see what you mean with testing VSCode. I spent as much time as I can working through mocks and didn't succeed mocking WorkspaceConfiguration, configuration.get.

Everything else has been addressed! Thank you again for the feedback. I think this is good to go, but open to more discussion 🤝

• [x] setting name should be expanded to statusBarLabel, have enabled and disabled properties, and include the icon
• [x] the DEFAULT const can be removed, using package.json as the default value
• [x] amend history, removing the .vsix build
• [x] update README.md with notes on configuration values/treatment, and a link to codicons reference
  • [x] add section before the examples in the customization section
• [x] settings should be reflected immediately, without full reload of VSCode windows
  • [x] moving configuration.get into getStatusBarText should resolve this
• [x] tests should be timeboxed to two hours. If changes can be tested, great, but limit time spent

[dgrebb]

@Tom-Bonnike I pulled your suggested changes and vsce started failing. Rolled back to where the branch was before changing — 2454461 is where things stand.

[dgrebb]

Also, the SVGs will get flagged by vsce now that they have a policy in place on the extensions market.

[Tom-Bonnike]

Hey, sorry I’m struggling to find time to take a look at this, aiming to test, merge & release before the end of the month 👀

[dgrebb]

@Tom-Bonnike I also lost track — no worries! Thank you for the collaboration and merge 😄

[Tom-Bonnike]

https://github.com/Tom-Bonnike/vscode-formatting-toggle/issues/67#issuecomment-1744729792 just to make sure you saw that, I'm very grateful for your work Dan!