search

Tom-Hirschberger / MMM-MplayerRadio

An MagicMirror² module which playes m3u radio playlists with MPlayer and supports various stations to rotate through
MIT License
7 stars 0 forks source link

Should stop station on exit #18

Closed thierry7100 closed 2 years ago

thierry7100 commented 2 years ago

Hi,

First, thanks for this module ! I found a slight issue, when magic mirror exit, mplayer doesn't stop. A stop function in the node_helper.js like this one corrects this problem.

stop: function () { const self = this self.stopStation(false) },

Tom-Hirschberger commented 2 years ago

Hi,

as mplayer had been run as an sub-process of electron it had been stopped with the electron process in previous versions maybe this behavior changed in recent versions. I will check your solution and release a new version if it works.

Tom-Hirschberger commented 2 years ago

Thank you. Your fix worked great. Version 0.0.9 contains the fix now