Tom-Hirschberger / MMM-OpenWeatherForecast

Magic Mirror weather module using OpenWeather API
8 stars 2 forks source link

Replace axios by internal fetch #4

Closed KristjanESPERANTO closed 2 months ago

KristjanESPERANTO commented 2 months ago

Besides replacing axios I also fixed some typos and changed formating. Checkout the commit messages for details.

I hope I didn't overload the PR.

Tom-Hirschberger commented 2 months ago

Hi and thanks again. I will take a closer look as fast as I can but I am pretty sure I will not be able to check all details in the next days.

I used axios in one of my other modules as I find the api a little bit more comfortably.

But one dependency less means one possible problem less.

Tom-Hirschberger commented 2 months ago

Sometimes things are easier than thought.

The changes all look good to me.

Thank you for the effort. I will merge shortly.