search

Tom-Moij / jamming

0 stars 0 forks source link

Summary #12

Open davecastlevania opened 6 years ago

davecastlevania commented 6 years ago

You did a great job with this project. I loved how there was extra functionality in this app with the audio player. I also like how you were able to modify the CSS to make the player happen. Very much beyond what I normally expect to see in this project. One way to improve this that I would recommend is make the player stop when previewing another song. Great job with this one and keep this up!

Summary: Beyond Expectations

Tom-Moij commented 6 years ago

I am really glad you liked it, I actually tried fixing the audio players to stop playing if an other was playing, but sadly couldn't get this to work.

It sure is something I am looking to learn more about 👍

Thank you again for the amazing review 💯

davecastlevania commented 6 years ago

I think it should be something where you program a function or method to track the "state" of the music player and to base your "currently playing" around that. There might be 3rd party React Music Players on Github if you search that you can look at their code and see how it works.