search

Tom-evnut / TeslaBMSV2

39 stars 32 forks source link

wrong value reset in battery settings menu #18

Closed stxShadow closed 4 years ago

stxShadow commented 4 years ago

If i set a value for "h" -> "j" will be reset to "0"

h - Discharge Current Taper Offset: 300mV
j - Discharge Current Temperature Derate : 40.00C

h 200

after that:

h - Discharge Current Taper Offset: 200mV
j - Discharge Current Temperature Derate : 0.00C

Tom-evnut commented 4 years ago

Thanks for the catch, for got a few “Break;” after case declarations.

From: stxShadow notifications@github.com Sent: Sunday, March 22, 2020 8:30:01 PM To: tomdebree/TeslaBMSV2 TeslaBMSV2@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [tomdebree/TeslaBMSV2] wrong value reset in battery settings menu (#18)

If i set a value for "h" -> "j" will be reset to "0"

h - Discharge Current Taper Offset: 300mV j - Discharge Current Temperature Derate : 40.00C

h 200

after that:

h - Discharge Current Taper Offset: 200mV j - Discharge Current Temperature Derate : 0.00C

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftomdebree%2FTeslaBMSV2%2Fissues%2F18&data=02%7C01%7C%7Cbcd009e2c1ff4428e36508d7ce9fcc3d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637205058020922201&sdata=RoE1DqZCMhOdOk%2Bc27tiOmSZxhX6cPtNeMxyGod1oqo%3D&reserved=0, or unsubscribehttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGFPAFWZNXQZX3CMRG7KOTTRIZYMTANCNFSM4LRNTIJA&data=02%7C01%7C%7Cbcd009e2c1ff4428e36508d7ce9fcc3d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637205058020932196&sdata=FGfjORsIqeo0OklFYqOisr5DS0WfNx%2BuRgLhr1ktuSY%3D&reserved=0.

stxShadow commented 4 years ago

You are welcome :)

Hope you got my mail to you gmail account too ? Regarding SOC and Victron ESS.