Tom-evnut / TeslaBMSV2

39 stars 32 forks source link

only cosmetical -> double display value #3

Closed stxShadow closed 4 years ago

stxShadow commented 5 years ago

Serial2.print("firm.val="); Serial2.print(firmver); Serial2.write(0xff); // We always have to send this three lines after each command sent to the nextion display. Serial2.write(0xff); Serial2.write(0xff); Serial2.print("firm.val="); Serial2.print(firmver); Serial2.write(0xff); // We always have to send this three lines after each command sent to the nextion display. Serial2.write(0xff);

Double serial output of the firmware version to Nextion Display.

It would be quite nice to have a page with the actual cell voltages ....

Maybe i can contribute that to your project ?

Jens

stxShadow commented 5 years ago

just to simplify the write(0xff):

you can use: byte NextionTerminator[3] = {255,255,255}; // global declaration

Serial2.print("firm.val="); Serial2.print(firm); Serial2.write(NextionTerminator,3);

etc ..... should shorten the whole thing

Tom-evnut commented 4 years ago

Fix implemented, will think about the shortening of coding with the array.