search

Tom4nt / Mega-Soundboard

Play and manage sounds with keybinds.
MIT License
12 stars 1 forks source link

Cannot set PTT key when updating from 0.5 #47

Closed Noctabou closed 1 year ago

Noctabou commented 1 year ago

On this pc i used MegaSoundboard 0.5.2, and i updated to 0.6.1, but i can't bind Random sound Key nor PTT key because the file location is empty. image

Steps to reproduce bug Download 0.5.2, update to 0.6.x, try setting a key in the app settings.

Environment:

Tom4nt commented 1 year ago

You aren't supposed to be able to leave that field empty even in 0.5.2, so I don't know how that happened. I tried to reproduce but I couldn't. Anyway, I'll make it fill in automatically with the default value if empty. For now, you can just use the default path, if you want: C:\Users\username\AppData\Roaming\MegaSoundboard\Sounds.

Thanks for the bug report! 👍

Noctabou commented 1 year ago

I think it doesn't work... It will always empty itself 5LbMCmlmz3

Tom4nt commented 1 year ago

Can you open the Dev Tools by pressing Ctrl Shift I? In the console tab, can you please check if there's an error there after you save the Settings and, if so, post the error here? Thank you.

Noctabou commented 1 year ago

VZaXH4wmxs 3 bundle.js:3163 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'length') at Keys.toKeyStringArray (bundle.js:3163:38) at set keys [as keys] (bundle.js:629:50) at SettingsModal.load (bundle.js:2461:41)

Tom4nt commented 1 year ago

I was able to reproduce the issue and find the cause. 0.5.2 sets some fields as null but 0.6.1 does not support that. It will be fixed soon. For now, to fix the settings, you can fill all the key fields with any keybind, and also the sound location. Then save, reopen the settings and delete the unwanted keybinds (right click). It should start working properly from that point on.

Thanks for the contribution!