search

Tom4nt / Mega-Soundboard

Play and manage sounds with keybinds.
MIT License
12 stars 1 forks source link

Pausing sound only pauses primary output #48

Closed JumpOff7667 closed 1 year ago

JumpOff7667 commented 1 year ago

Hi, First of all thanks for this amazing soundboard app. I use it all the time.

Since the new update that adds the Seekbar, when I click on the pause button only the "Main device" gets paused, but not the secondary device, which is currently my earphones.

I don't know much about Electron and typescript, but I think that it is due to the fact that Seekbar can only get set a single HTMLMediaElement (which is the HTMLAudioElement) while it must have two HTMLMediaElements: one for the "Main device" and another for the "Secondary device".

If you can have a look it would be great!

Steps to reproduce:

  1. Set the "Main device" and the "Secondary device".
  2. Create a sounds preset.
  3. Add a sound to that preset.
  4. Click on the newly added sound.
  5. Press the pause button on the Seekbar.

Environment:

Tom4nt commented 1 year ago

Thanks for the bug report! You're right. I possibly forgot to control both media elements. This will be fixed as soon as I can.

JumpOff7667 commented 1 year ago

Thanks for the fix! Unfortunately, another bug appeared. The Seekbar doesn't show the current progress of the sound, it is always stuck at the middle.

EDIT: It seems random, you have to click several times on the sound and the bug will appear.

Tom4nt commented 1 year ago

I can't reproduce that issue even if I click several times on the same/other sounds. I tried doing that for a few minutes and everything worked fine. Note that the Seekbar only appears if there's exactly one sound playing. If you find more details about the issue, please provide them. Thank you.

Tom4nt commented 1 year ago

I have found the cause of the issue and also 2 more in the process. They will all be fixed in the next patch.