Crash when Windows is closing

[Noctabou]

MegaSounboard is crashing when i shutdown my Windows, and it says that a stop point was accessed, error 0x80000003 at 0x00007FF70FA8C271

Theses are my settings I also configured my Windows to make MegaSounboard start on login

Environment:

• OS : Windows 11 22H2
• Mega Soundboard version : 0.6.3

[Tom4nt]

Thanks for the bug report! Looks like it's an electron bug. As this comment states, it should be fixed by not using event.preventDefault() in the on('close') event. I'm using event.preventDefault() because the app does some async work before shutting down. As a workaround, I may have to use synchronous alternatives. I'll investigate that soon.

Just a question: Does it prevent Windows from shutting down? Do you have to click "OK"?

[Noctabou]

Yes, it prevents Windows from shutting down, i have to click OK, that's a bit annoying. Also, it's weird because it doesn't happen everytime.

[Tom4nt]

I was unable to reproduce the bug, but I did what I said in my last comment. Can you use the patched version for a while to see if the bug still occurs (you can comment here if it does)? It's better to make sure it's fixed before making a release. The fix is in the master branch. I've built a binary so you don't have to, but you can build it yourself if you want.

[Noctabou]

I trust you, and downloaded from the drive. I just installed it, if it ever happen again, i will tell you here. Because i use it really often, let's say it's good in less than a month ? Thank you for maintaining this app, it's one of my biggest finding on Github ^^

[Tom4nt]

Sure, since only you know how often it happens, it's better for you to decide when it can be considered fixed or not. And thank you for your words, they really motivate me to keep developing this app. :)

[Noctabou]

Guess who's back Mhh but i'm not sure it's installed properly since there is no difference. I didn't uninstall + install the version you given me, i simply overrided the old installation. So i think it's installed properly but idk. If you want, i can try next time it appears to click Debug instead of closing (i'm learning code so i think i can help a little) Anyway, if you want to talk more about it, maybe you should add me on Discord (or something else, just to have instant chatting) (same username everywhere)

[Tom4nt]

I confirmed locally that it gets installed properly if it gets overwritten, so you should have the patch. It just didn't fix the problem, which was expected, as the solution has been just an assumption. I'll add you on Discord so we can hopefully diagnose this.

[Tom4nt]

I still can't reproduce this, but Noctabou informed me that it is no longer happening. This issue will be reopened if it happens again.