search

Tom94 / tev

High dynamic range (HDR) image viewer for graphics people
BSD 3-Clause "New" or "Revised" License
1.03k stars 87 forks source link

Switch to TCP for IPC #104

Closed mmp closed 4 years ago

mmp commented 4 years ago

(Only tested on OSX, but everything seems to work.)

I made a rudimentary attempt to get the Windows stuff wired up but am sure it's broken.

Tom94 commented 4 years ago

Thanks a lot for the PR, Matt. Works like a charm!

I quickly fixed up formatting, finished Windows support, and added a bunch of extra error handling for additional corner cases.

Could you let me know if things still work on your end before I press the green button? (I was able to test macOS and Windows, but not linux beyond CI.)

mmp commented 4 years ago

Great! (And sorry for leaving the Windows stuff on your plate...)

Unfortunately I haven't been able to text on Linux: my linux system is head-less and I've thus far been unsuccessful at getting remote X-windows stuff to work with it.

My only comment is regarding 2c84063923ab157dc: if I revert that, I can successfully render on Linux and display remotely on OSX, which is nice to be able to do. (And with that in place, I'm not able to.) Admittedly I don't know enough about networking to understand the underlying concerns, but it would be nice to be able to do that, at least as an option..

On Tue, Jun 9, 2020 at 1:07 AM Thomas Müller notifications@github.com wrote:

Thanks a lot for the PR, Matt. Works like a charm!

I quickly fixed up formatting, finished Windows support, and added a bunch of extra error handling for additional corner cases.

Could you let me know if things still work on your end before I press the green button? (I was able to test macOS and Windows, but not linux beyond CI.)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Tom94/tev/pull/104#issuecomment-641110319, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZBJ3SB7LRTOYSHZ4EDHTRVXUUDANCNFSM4NY33N5A .

Tom94 commented 4 years ago

No problem at all! :)

You should already be able to remote-render as long as you pass the correct (non-local) hostname to tev for binding: i.e. start the tev server using

tev --hostname your-local-network-ip:14158

mmp commented 4 years ago

Ah, yes--confirmed: --hostname with the actual IP address works in that case. Thanks!