search

Tom94 / tev

High dynamic range (HDR) image viewer for graphics people
BSD 3-Clause "New" or "Revised" License
1.08k stars 86 forks source link

Add support for HDR/Apple EDR displays as well as 10 bit color #130

Closed Tom94 closed 3 years ago

Tom94 commented 3 years ago

Adding this support entailed updating tev to the latest (non-backwards-compatible) version of nanogui, which entailed

This means that there is significant potential for breakage and bugs, so I'm waiting with pushing out a binary release and leaving my fingers crossed that everything will be ironed out by those folks who stay up to date with master. (Thank you very much! :))

In other news: due to the newer nanogui, tev now requires a C++17-capable compiler.

KarelPeeters commented 3 years ago

The nanogui dependency doesn't compile for me on windows, the function childCount() here does not exist, that should probably have been child_count? Strange that the CI didn't catch this, or maybe I did something wrong.

Tom94 commented 3 years ago

The nanogui dependency doesn't compile for me on windows, the function childCount() here does not exist, that should probably have been child_count? Strange that the CI didn't catch this, or maybe I did something wrong.

Good catch, thanks! The bodies of assertions are only compiled in debug mode -- yet another example of why C macros are a bad thing.