search

Tom94 / tev

High dynamic range (HDR) image viewer for graphics people
BSD 3-Clause "New" or "Revised" License
1.02k stars 86 forks source link

Ctrl+number cannot select channel groups on Linux/Windows #229

Closed MKimiSH closed 1 month ago

MKimiSH commented 1 month ago

I believe the cause is the !(modifiers & SYSTEM_COMMAND_MOD) in the following line: https://github.com/Tom94/tev/blob/13352738362d65d1b89dea4b81d8756bb5cc1368/src/ImageViewer.cpp#L686. On Windows and Linux, this is the same as Ctrl, so it blocked the Ctrl+number key combination. This seems related with introducing Ctrl/Cmd+0 and Ctrl/Cmd+9 for setting image transforms.

I think the new Ctrl+0/9 behavior is more useful than selecting the 9th or 10th channel group. Meanwhile, we can perhaps keep Ctrl+[1-8]? It introduces a bit of inconsistency though.

Tom94 commented 1 month ago

Oops, good catch! Thanks & sorry for the accidental breakage. Just pushed a fix that makes Ctrl+1-8 work (I agree 9 and 0 aren't necessary here).