search

Tom94 / tev

High dynamic range (HDR) image viewer for graphics people
BSD 3-Clause "New" or "Revised" License
1.03k stars 87 forks source link

Closing the app with ESC is annoying #84

Closed luksladky closed 2 years ago

luksladky commented 4 years ago

It might my personal issue, but I keep closing tev by accident all the time. Am I the only one?

Wagyx commented 4 years ago

No, you are not, it happened to me a few times at first too. I don't do it anymore though. Maybe a different input like Ctrl+Q would be good instead.

MKimiSH commented 4 years ago

I think Q alone quits tev as well. Esc is probably the default with NanoGUI?

Tom94 commented 2 years ago

I'm torn on this one -- and been putting it off far too long. :)

Could any reader of this comment vote for/against closing via Esc using thumbsup/thumbsdown reactions? I'll do what the majority decides.

MKimiSH commented 2 years ago
  1. Why do we allow two keys for quitting tev? It will make sense to close with Esc if Q is assigned another task.
  2. If it's not too difficult, maybe it's better to have a confirmation pop-up after pressing Esc or Q which now directly quits tev. This will force a two-key (or more) sequence, like Esc-Enter or Q-Enter, and reduce the possibility of accidents.
Tom94 commented 2 years ago
  1. Why do we allow two keys for quitting tev? It will make sense to close with Esc if Q is assigned another task.

I personally don't feel strongly about Esc, except for a slight leaning towards keeping it to not break anyone's workflow. Hence the vote. From the current state of it, it looks like I'll end up removing the shortcut with the next release. :)

2. If it's not too difficult, maybe it's better to have a confirmation pop-up after pressing Esc or Q which now directly quits tev. This will force a two-key (or more) sequence, like Esc-Enter or Q-Enter, and reduce the possibility of accidents.

The point of the Q shortcut is to have an easily accessible (left hand; no finger gymnastics) and quick way to close the program. A confirmation dialog would run directly counter to that.

That said, Ctrl/Cmd+Q sounds like a good way forward to me

MKimiSH commented 2 years ago

I see your points. Ctrl/Cmd+Q sounds much nicer than an additional dialog.