Bug: E-mail confirmation contains local http://localhost:8222

TomBursch / kitchenowl

KitchenOwl is a self-hosted grocery list and recipe manager. The backend is made with Flask and the frontend with Flutter. Easily add items to your shopping list before you go shopping. You can also create recipes and add items based on what you want to cook.

https://kitchenowl.org/

GNU Affero General Public License v3.0

1.24k stars 68 forks source link

Bug: E-mail confirmation contains local http://localhost:8222 #423

Closed robotter112 closed 5 months ago

robotter112 commented 6 months ago

Is this urgent?

What parts are affected

Backend

What is the server version

v93

What is the client version

v0.4.21 (92)

What platform are you using

Web

What's the problem 🤔

When I send the confirmation email to a user, the confirmation link does not contain the domain http://localhost:8222/confirm-email?t=e627f854787d42246p18a541bacf65cdf30.

However, I have set the environment in the backend container: FRONT_URL: https://shopping.domain.de

Share your logs

I haven't found anything relevant in the logs.

Share your configuration

KitchenOwl-Web:
BACK_URL=192.168.0.010:5000

KitchenOwl:
FRONT_URL=https://shopping.domain.de
SMTP_HOST=mail.domain.de
SMTP_PORT=465
SMTP_USER=noreply@domain.de
SMTP_FROM=noreply@domain.de
SMTP_PASS=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

TomBursch commented 6 months ago

Have you tried restarting the backend? Whenever you change an environment variable you'll need to restart it.

robotter112 commented 6 months ago

Yes, I have restarted both containers, but the link in the email is still incorrect.

TomBursch commented 6 months ago

I've just published a new version, can you confirm if this is still happening?

robotter112 commented 6 months ago

I have previously updated to version 0.5.0 (94)

I registered with a new e-mail and the confirmation link still looks the same. http://localhost:8222/confirm-email?t=775d2455647241ad8109e58dbbf20d67

robotter112 commented 5 months ago

I did some more trial and error and found that it also uses http://localhost:8222/signin/redirect as the redirect URL for SSO.

I don't know if I already mentioned it, but my kitchenowl is running in unraid.

TomBursch commented 5 months ago

I don't know if I already mentioned it, but my kitchenowl is running in unraid.

That explains it. You can create an issue for this with the unraid template maintainer here https://codeberg.org/HanSolo97/unraid-template-kitchenowl