search

TomBursch / kitchenowl

KitchenOwl is a self-hosted grocery list and recipe manager. The backend is made with Flask and the frontend with Flutter. Easily add items to your shopping list before you go shopping. You can also create recipes and add items based on what you want to cook.
https://kitchenowl.org/
GNU Affero General Public License v3.0
1.12k stars 62 forks source link

fix: Update network_security_config.xml #433

Closed coderph0x closed 2 months ago

coderph0x commented 2 months ago

fix: Added user-defined certificates, so that custom CAs that are installed on the device should be respected (discussed in https://github.com/TomBursch/kitchenowl/issues/236)

thatso commented 2 months ago

@coderph0x great find! However, your reference has lines 5 and 6 swapped with user first:

<certificates src="user"/>
<certificates src="system"/>
coderph0x commented 2 months ago

@coderph0x great find! However, your reference has lines 5 and 6 swapped with user first:

<certificates src="user"/>
<certificates src="system"/>

Hope this isn't too relevant. Unfortunately, setting up the dev environment failed for me, so I wasn't able to test this.

TomBursch commented 2 months ago

Thanks for the PR, I'm still not sure if this will actually fix #236. The issue you've linked talks only about webview which likely uses an android native library. For connecting to the server, KitchenOwl uses the HTTP client written in dart. This is definitely needed anyway, but I'm not sure if the dart HTTP client can use the added certificates. We'll see 😄