search

TomCasavant / MastodonPlaysGameboy

Lets users play gameboy roms via mastodon polls
MIT License
14 stars 2 forks source link

Fixed tie-vote handling #39

Closed lukemurphy147 closed 2 months ago

lukemurphy147 commented 3 months ago

Resolves #6

I'm confident that this code properly handles tie votes now by choosing a random button out of those that tied. However, I'm not so sure about the formatting of top_result, since self.random_button() and self.take_action use different strings for the buttons.

TomCasavant commented 3 months ago

Oh shoot, you're right I didn't notice that. I think I'd prefer if they all showed the emoji in the text so they line up with when a button is actually chosen. If you want to put that in this PR feel free, otherwise I'll just create another issue for it since it's not a huge deal and I'll just go ahead and merge this one in

lukemurphy147 commented 3 months ago

So it's okay if status contains the emojis? Right now it doesn't.

image

TomCasavant commented 3 months ago

Yes I'd prefer if it shows the emoji like it does for successful votes

Screenshot_20240628_191349_Tom-Moshidon Debug.jpg

https://tomkahe.com/@pokemon/112694359534888570

lukemurphy147 commented 2 months ago

OK, the emoji formatting should be consistent now, along with some other things that were bugging me but didn't affect the program logic (gameboy -> Game Boy, mastodon -> Mastodon, etc.) Also, I folded random_button() into take_action() because I felt they were too similar.