search

TomCodd / NutritionTools

Tools for the Organisation, Matching, Calculation, and Summarisation of Nutrition Data
https://tomcodd.github.io/NutritionTools/
0 stars 1 forks source link

Bugs: Group_summariser #4

Closed LuciaSegovia closed 11 months ago

LuciaSegovia commented 11 months ago 
          Hi @LuciaSegovia !

Sorry, thats definitely a problem - can you send me the dataset you were trying it with (i.e. save it as an R data file just before it was input into the Summariser) , and the group summariser command you were running? I'll see if I can sort it :)

Originally posted by @TomCodd in https://github.com/TomCodd/NutritionTools/issues/2#issuecomment-1827595435

LuciaSegovia commented 11 months ago

I think it's better to take this into a separate thread, as the other should be for new functions ideas 😅

TomCodd commented 11 months ago

Yeah, definitely haha :)

TomCodd commented 11 months ago

Hi @LuciaSegovia - This should now be fixed :) The bug was that any errors were being attributed to the first group ID on the list (1001 in this case), but the error message was caused by a different group (1002) for a legitimate reason - the weightings total ~ 0.75 :)

Please can you reinstall and make sure thats now working for you? :)

LuciaSegovia commented 11 months ago

Thank you @TomCodd ! It run perfectly on my side :) . Although I found another issue. See in the picture attached, that the id is missing in the summary row. I think this will cause problems down the line.

image

TomCodd commented 11 months ago

Hi @LuciaSegovia !

Hmmm - missing the item_desc you mean?

LuciaSegovia commented 11 months ago

Sorry @TomCodd! What I meant is if you check row 5 and row 7, it should say "SUMMARY ROW - 1002" and "SUMMARY ROW - 1004" respectively, instead of "SUMMARY ROW - NA".

TomCodd commented 11 months ago

Thats ok @LuciaSegovia !

Ah, ok - I see what you mean. I'll look into it now :) Theres also the row order I want to double check. Did you make any other changes to that dataset since you sent it to me, aside from adding pork lard?

LuciaSegovia commented 11 months ago

Thank you @TomCodd!

I am doing some changes to the dataset, but they should be irrelevant to the summariser.

TomCodd commented 11 months ago

No problem @LuciaSegovia , thank you for finding them!

I've solved that problem - give it a minute for the website to update and please could you try installing the package again, and see if its working for you too? :)

LuciaSegovia commented 11 months ago

@TomCodd it's not working for me :(

TomCodd commented 11 months ago

@LuciaSegovia :(

Apparently the push didn't work lol - sorry! Give it a minute or two, reinstall and try again? :)

LuciaSegovia commented 11 months ago

Thank you @TomCodd !! It's working!! YAY!

TomCodd commented 11 months ago

@LuciaSegovia Glad its working!! :)