search

TomCools / dropwizard-websocket-jsr356-bundle

A Dropwizard bundle that enables the usage of the Java API for WebSocket Protocol (JSR 356).
Apache License 2.0
22 stars 14 forks source link

Support for Dropwizard 3.x #15

Open BastienDurel opened 1 year ago

BastienDurel commented 1 year ago

Hello.

It would be nice if Dropwizard 3.x could be added. Only a few import/interface renames are needed. (dropwizard-websocket-jee7-bundle cannot be used as jetty version changed (and some base DW classes changed package))

I've done that on https://github.com/BastienDurel/dropwizard-websocket-jsr356-bundle/tree/dropwizard_3 (with only a version chnge, don't know if a new artifact name would be better)

TomCools commented 1 year ago

I could introduce a new 3.x branch for that to work! However; I'd like to motivate people to jump on the newer 4.x. If this 3.x is requested by a few more people (by commenting here), then I'll do it. 👍

YSavitski commented 1 year ago

Hi @TomCools Will be latest release 4.x available and accessible on the maven-central? I may see that 2.1.6 is the last avaialble version

Thx in advacne

image

TomCools commented 1 year ago

Hi @TomCools Will be latest release 4.x available and accessible on the maven-central? I may see that 2.1.6 is the last avaialble version

Thx in advacne

image

I forgot to update the badge in the readme it seems. The 4.x release has been on Maven Central for a while, https://mvnrepository.com/artifact/be.tomcools/dropwizard-websocket-jsr356-bundle. Note the change in artifact name.

YSavitski commented 1 year ago

Hi @TomCools Will be latest release 4.x available and accessible on the maven-central? I may see that 2.1.6 is the last avaialble version Thx in advacne image

I forgot to update the badge in the readme it seems. The 4.x release has been on Maven Central for a while, https://mvnrepository.com/artifact/be.tomcools/dropwizard-websocket-jsr356-bundle. Note the change in artifact name.

Hi @TomCools Thank you for hint with link !

spags-lacework commented 1 month ago

This would be awesome to have to make upgrading Dropwizard easier, as I could stage it from 2->3, then 3->4. In someways it would be better to go just from 2->4, but I'm trying simplify the number of libraries to upgrade.