TomDmitriev / gradle-bundle-plugin

Apache License 2.0
47 stars 24 forks source link

always set base directory for bndlib Builder #23

Closed gamerson closed 9 years ago

gamerson commented 9 years ago

Hey @TomDmitriev

After a few months absence I'm back working with your gradle-bundle-plugin again. Just so you know I'm working on migrating a large collection of bnd projects that current use ant scripts to drive the build and I'm one-by-one trying to move them to gradle your gradle-bundle-plugin.

Thanks so much for your work on this so far, its really good stuff.

So the most recent snag I hit I posed as #22

This pull request fixes that issue by setting the base directory of the bndlib Builder for each project so multi-project builds or "working dir outside of project dir" works as expected.

gamerson commented 9 years ago

FYI I think that travis-ci build failed because the invocation of the gradle builds in the integration tests are using the locally build one but instead using latest release 0.6.1.

When I was testing locally I had to run a "publishToLocalMaven" so "latest.integration" dependency in the test build.gradle would pickup the local one. Maybe we could modify the travis command to do that too?

gamerson commented 9 years ago

I'll send another pull that contains a fix for #24 as well.