search

TomFreudenberg / next-auth-mock

NextAuth.js mockup provider for jest, storybook and others.
MIT License
28 stars 1 forks source link

fix: adds next-auth and react as peerDependencies #6

Closed emiliosheinz closed 1 year ago

emiliosheinz commented 1 year ago

Fixes "[next-auth]: useSession must be wrapped in a " when there is a version mismatch

emiliosheinz commented 1 year ago

@TomFreudenberg I've used yarn during the install process since I haven't found any lock file.

TomFreudenberg commented 1 year ago

Please drop file yarn.lock as well.

I use pnpm some yarn some ... - so I like to leave it to everyone

emiliosheinz commented 1 year ago

Please drop file yarn.lock as well.

I use pnpm some yarn some ... - so I like to leave it to everyone

Done

TomFreudenberg commented 1 year ago

And please add yourself also to the new CONTRIBUTORS.md file in root

emiliosheinz commented 1 year ago

And please add yourself also to the new CONTRIBUTORS.md file in root

Do you have any example of how this file should look like?

TomFreudenberg commented 1 year ago

I have already created that for you

https://github.com/TomFreudenberg/next-auth-mock/blob/master/CONTRIBUTORS.md

you only need to pull once from my master

TomFreudenberg commented 1 year ago

Looks great - merge now !!!

TomFreudenberg commented 1 year ago

@emiliosheinz Thanks a lot for help and figure out the bug!

It's online as release 0.5.6 on npmjs.

Looking forward to next conversation 👍🏻

emiliosheinz commented 1 year ago

@TomFreudenberg It would be nice to have the "Discussions" session opened in this repo. So we can discuss the improvements before actually working on them and the issues session doesn't get crowded.

TomFreudenberg commented 1 year ago

If it is OK for you, let's stay with issues please. I find that the discussion are often have a missing focus. If you check the issue labels (not sure if I have to set as maintainer) we can mark the issues as discussions and improvements. I can open a project-map (kanban) so that we put all relevant tickets at one place.

TomFreudenberg commented 1 year ago

@emiliosheinz you should have now write permissions to the project board.

emiliosheinz commented 1 year ago

Ok. I'll be opening some discussions (or issues 😅) within the next weeks so that we can discuss them. Thank you for your attention and quick responses!

TomFreudenberg commented 1 year ago

Thank you too!