search

TomFrost / Bristol

Insanely configurable logging for Node.js
MIT License
113 stars 19 forks source link

Fix package.json, Fix syslog formatting to use day-of-month instead of day-of-week #19

Closed slester closed 7 years ago

slester commented 8 years ago

As it is, the syslog formatter uses d instead of D, which will log the day of the week instead of the day of the month, giving us nonsense like:

Aug 0 05:38:31 localhost node /var/www/project/index.js[5798]: severity=warn file=/var/www/project/file.js line=27 hostname=localhost userAgent="Mozilla/5.0 (X11; CrOS x86_64 8350.68.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36" message="test" data=null now=19630.170000000002 userTime=2016-08-27T22:39:01.440-07:00 state=null

slester commented 8 years ago

I also updated package.json to use the proper path to the Bristol.js (this is currently broken in the master branch).

MarkHerhold commented 7 years ago

This can be closed, it was fixed in https://github.com/TomFrost/Bristol/pull/27

slester commented 7 years ago

Is there a reason this PR was ignored and the other was accepted? I'd like to know so I can contribute better in the future. Thanks.

MarkHerhold commented 7 years ago

@slester I think Tom is just busy and missed it. There's nothing wrong with the PR IMO.

TomFrost commented 7 years ago

Apologies @slester! I was going top-down and didn't realize it was a duplicate, otherwise I'd have favored yours since it was first. I'm working on polishing up a 1.0-rc1 release for next week, so this will be in there.

slester commented 7 years ago

It's OK! I just wanted to make sure that I did things in the proper way; we've been using my fork in production so it'll be nice to be able to switch back to 1.0 when it's fully vetted!