Handling of identifiers starting with $

TomFrost / Jexl

Javascript Expression Language: Powerful context-based expression parser and evaluator

MIT License

573 stars 94 forks source link

Handling of identifiers starting with $ #36

Closed glromeo closed 5 years ago

glromeo commented 7 years ago

Hi Tom,

thank you for Jexl, it's a pretty neat library!

I encountered an issue in the Lexer that I had to fix for me to be able to use it in my framework. I added a test that covers the issue.

When I cloned the forked repository I also had to do a bit of tidy up to make gulp work with the latest node.

I hope that you might find my efforts useful,

Kind Regards

Gianluca Romeo

TomFrost commented 7 years ago

Thanks Gianluca! This is definitely a use case I hadn't considered.

I'm about 95% done merging the 2.0 branch down to master, which, due to a style update, pretty significantly changes all files. Bear with me-- I'll merge this in as soon as I can do it without headaches :)

TomFrost commented 5 years ago

I apologize for the insane delay on this! I just pushed this to master, but due to the huge number of conflicts, did not merge from this PR. I've given you credit in the changelog!