TomHarte / CLK

A latency-hating emulator of: the Acorn Electron and Archimedes, Amstrad CPC, Apple II/II+/IIe and early Macintosh, Atari 2600 and ST, ColecoVision, Enterprise 64/128, Commodore Vic-20 and Amiga, MSX 1/2, Oric 1/Atmos, early PC compatibles, Sega Master System, Sinclair ZX80/81 and ZX Spectrum.
MIT License
931 stars 52 forks source link

[OpenGL] Couldn't get location for uniform #1348

Open ryandesign opened 7 months ago

ryandesign commented 7 months ago

With the new logging code, I'm getting these new messages when starting clksignal (built with cmake) on my 2011 13" MacBook Pro running Linux Mint 21.2:

$ ./buildsdl/clksignal --new=AppleII
[OpenGL] Constructing scan target with OpenGL 3.3 (Core Profile) Mesa 23.2.1-1ubuntu3.1~22.04.2; shading language version 3.30
[OpenGL] Changed output resolution to 400 by 300
[OpenGL] Couldn't get location for uniform phaseOffset
[OpenGL] Couldn't get location for uniform compositeAngleOffsets
[OpenGL] Couldn't get location for uniform rgbToLumaChroma
[OpenGL] Couldn't get location for uniform rowHeight
[OpenGL] Couldn't get location for uniform scale
[OpenGL] Couldn't get location for uniform phaseOffset
[OpenGL] Couldn't get location for uniform compositeAngleOffsets
[OpenGL] Couldn't get location for uniform lumaChromaToRGB
[OpenGL] Couldn't get location for uniform rgbToLumaChroma
^C

In the case of the Apple II emulation it still works but I have to press Control-C to terminate it; closing the window doesn't do so. Neither the OpenGL messages nor the failure to quit after closing the window used to happen with a scons build from a month or two ago. I suspect it has less to do with the build system and more with changes to the main code but I have not bisected yet to see if I could identify what caused it. Let me know if you want me to try that.

I also tried the Macintosh emulation:

$ ./buildsdl/clksignal --new=Macintosh
[OpenGL] Constructing scan target with OpenGL 3.3 (Core Profile) Mesa 23.2.1-1ubuntu3.1~22.04.2; shading language version 3.30
[OpenGL] Couldn't enable vertex attribute startCompositeAngle
[OpenGL] Couldn't enable vertex attribute endCompositeAngle
[OpenGL] Couldn't enable vertex attribute lineCompositeAmplitude
[OpenGL] Changed output resolution to 400 by 300
[OpenGL] Couldn't get location for uniform phaseOffset
[OpenGL] Couldn't get location for uniform compositeAngleOffsets
[OpenGL] Couldn't get location for uniform lumaChromaToRGB
[OpenGL] Couldn't get location for uniform rgbToLumaChroma
[OpenGL] Couldn't get location for uniform qamTextureName
[OpenGL] Couldn't get location for uniform compositeAngleOffsets
Killed

In this case, the emulator window opened but was empty/black and did not redraw properly when resizing the window, and attempting to close the window didn't do anything. The OS eventually brought up a message saying the program wasn't responding. I know the Macintosh emulation worked in the month-or-two-old build because I remember showing it to a friend on this computer recently.