search

TomHarte / CLK

A latency-hating emulator of: the Acorn Electron and Archimedes, Amstrad CPC, Apple II/II+/IIe and early Macintosh, Atari 2600 and ST, ColecoVision, Enterprise 64/128, Commodore Vic-20 and Amiga, MSX 1/2, Oric 1/Atmos, early PC compatibles, Sega Master System, Sinclair ZX80/81 and ZX Spectrum.
MIT License
931 stars 52 forks source link

warning: this statement may fall through [-Wimplicit-fallthrough=] #1363

Closed ryandesign closed 5 months ago

ryandesign commented 5 months ago

Building the latest code from the repo on Linux with cmake (which uses -Wall -Wextra) and g++ 11.4.0, I get these warnings:

.../CLK/Machines/Amiga/../../Processors/68000/Implementation/68000Implementation.hpp:1867:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1867 |                         switch(instruction_.operand_size()) {
      |                         ^~~~~~
.../CLK/Machines/Amiga/../../Processors/68000/Implementation/68000Implementation.hpp:232:41: note: here
  232 | #define BeginState(x)                   case ExecutionState::x: x
      |                                         ^~~~
.../CLK/Machines/Amiga/../../Processors/68000/Implementation/68000Implementation.hpp:1881:17: note: in expansion of macro ‘BeginState’
 1881 |                 BeginState(StoreOperand_bw):
      |                 ^~~~~~~~~~