search

TomKnn / EindopdrachtMoodAndFood

0 stars 1 forks source link

Async #1

Open KaterinaLupacheva opened 2 years ago

KaterinaLupacheva commented 2 years ago

@TomKnn hi! It's Kate, from dev.to. I'd like to make a pull request with a piece of code of how to get all recipe ids in getRecipeByPreference.js file and use them in main.js file. Could you please add me as a collaborator to this repo? My github handle is katerinalupacheva.

TomKnn commented 2 years ago

Hi Kate! Sure thing, I`ve added you. I hope i've done it correctly ;) Again, thanks for your help! 👍

KaterinaLupacheva commented 2 years ago

@TomKnn yep, you did everything right! Please check my PR

TomKnn commented 2 years ago

Hey Kate!

Didn`t expect to get an answer on sunday ;) Thanks for your time!!

Im sorry if Im asking weird or stupid stuff, I get perfect results here https://github.com/TomKnn/EindopdrachtMoodAndFood/pull/2/commits/0aa8a97c2ba90133e96147ddad106a46e4701a2d But to be honest, I still don`t understand how to pass this unto something else. When you say ' and then pass these ids to the next function ' - how would I write this down?

Greets, Tom

Op zo 19 jun. 2022 om 13:50 schreef Katsiaryna Lupachova < @.***>:

@TomKnn https://github.com/TomKnn yep, you did everything right! Please check my PR https://github.com/TomKnn/EindopdrachtMoodAndFood/pull/2

— Reply to this email directly, view it on GitHub https://github.com/TomKnn/EindopdrachtMoodAndFood/issues/1#issuecomment-1159702616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVIQAV4X5AJUNZWUL7YPGUDVP4CR5ANCNFSM5ZFHS5KQ . You are receiving this because you were mentioned.Message ID: @.***>

KaterinaLupacheva commented 2 years ago

most probably you need these ids to use somewhere for different purposes (for example, to make another API requests and pass an id as a param, or to filter some data by these ids, and so on). Then just pass these ids as argument to this function.

Could you please tell me where (in which function) do you plan to use these ids? What are you going to do with them in general?

p.s. I'm very busy on several projects during workdays, that's why my replies come on weekend:)

TomKnn commented 2 years ago

Id figure youd be very busy, so thank you very much again for your time and trouble👍👍

Idd the ids are necesarry for getting a recipecard image and also using them for a previous and next button to allow the user to scroll through these cards ( https://github.com/TomKnn/EindopdrachtMoodAndFood/tree/master/src/javascript/buttonFunction )

But youve helped me a great deal and there also teachers available to help me with the rest. Its great you help us beginners out, keep up the good work and best of luck with your work!

Warm regards, Tom

Op zo 19 jun. 2022 om 21:07 schreef Katsiaryna Lupachova < @.***>:

most probably you need these ids to use somewhere for different purposes (for example, to make another API requests and pass an id as a param, or to filter some data by these ids, and so on). Then just pass these ids as argument to this function.

Could you please tell me where (in which function) do you plan to use these ids? What are you going to do with them in general?

p.s. I'm very busy on several projects during workdays, that's why my replies come on weekend:)

— Reply to this email directly, view it on GitHub https://github.com/TomKnn/EindopdrachtMoodAndFood/issues/1#issuecomment-1159794163, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVIQAV74HSOKILDFNQXNDQDVP5VYJANCNFSM5ZFHS5KQ . You are receiving this because you were mentioned.Message ID: @.***>

KaterinaLupacheva commented 2 years ago

Thank you!

Happy to help! I was on your place (a newbie place) not so long ago and I remember the feeling and frustration very well)

Good luck with your studies!

Best regards, Kate

TomKnn commented 2 years ago

Not so long ago? Damn, you catch on fast😉 Code is fun but at the same time can be very frustrating idd.

Thanks👍, cheers!

Op ma 20 jun. 2022 om 14:32 schreef Katsiaryna Lupachova < @.***>:

Thank you!

Happy to help! I was on your place (a newbie place) not so long ago and I remember the feeling and frustration very well)

Good luck with your studies!

Best regards, Kate

— Reply to this email directly, view it on GitHub https://github.com/TomKnn/EindopdrachtMoodAndFood/issues/1#issuecomment-1160391855, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVIQAV65YI5MSNGBI4W4ACTVQBQHBANCNFSM5ZFHS5KQ . You are receiving this because you were mentioned.Message ID: @.***>