search

TomNeyland / angular-dc

AngularJS directives for dc.js
http://tomneyland.github.io/angular-dc/
MIT License
112 stars 59 forks source link

Edge version of dc.js breaks line charts #29

Open lfarrell opened 9 years ago

lfarrell commented 9 years ago

Line charts no longer appear to work, including your example NASDAQ line charts. They throw the following error: Error: An invalid or illegal string was specified. The issue appears to have been introduced in dc.js 2.0.0-alpha.3, as it works fine with dc.js 2.0.0-alpha.2.

Thanks,

Dean

lfarrell commented 9 years ago

Tom,

The issue appears to be that invalid clip path id's are being generated if you don't specify an id for a chart. For example, #1-clip is being generated for the first clip path if no id is specified. Since an id can't start with a number the selector fails. If I specify an id dc.js takes it and appends "-clip" to it, and everything works fine.

Apparently, dc.js 2.0.0-alpha.2 and lower were taking advantage of a bug when it generated ids, as #1-clip works just fine there. So, I'm not sure if this is a dc.js issue or an angular-dc issue. Hope this helps.

Thanks for all your hard work,

Dean

TomNeyland commented 9 years ago

@lfarrell Thanks for the bug report, will try to look into this soon.